Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use VPTeamMembers component from VitePress #1547

Merged
merged 12 commits into from
Jun 26, 2022
Merged

docs: use VPTeamMembers component from VitePress #1547

merged 12 commits into from
Jun 26, 2022

Conversation

userquin
Copy link
Member

This PR includes:

  • update VitePress to alpha-4
  • fix some color contrast on ::: tip and gray cards (home page for example)
  • switch Matías and Vlad team cards (request comes from Matías), also added a shield in Vlad card
  • update core team members module to match SocialLink in VitePress

I'll try to align entries on core team members cards via css styles.

@netlify
Copy link

netlify bot commented Jun 25, 2022 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit e3e956a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62b86e9e71d1c000080da6ed
😎 Deploy Preview https://deploy-preview-1547--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin marked this pull request as ready for review June 25, 2022 12:54
@antfu
Copy link
Member

antfu commented Jun 25, 2022

The sponsor links did not show up 🤔

@userquin
Copy link
Member Author

userquin commented Jun 25, 2022 •
edited
Loading

The sponsor links did not show up 🤔

something related with the PWA?
https://streamable.com/mvys0m

@patak-dev
Copy link
Member

It worked for me in an incognito window, but I also didn't see them now with my logged user. So looks like it is PWA related

@userquin
Copy link
Member Author

It worked for me in an incognito window, but I also didn't see them now with my logged user. So looks like it is PWA related

Can you check if the link (on mouseover) are ok? Chrome and Firefox just show the correct links for me: try reloading the page

@patak-dev
Copy link
Member

I don't see the links, and I tried reloading the page.

@userquin userquin marked this pull request as draft June 25, 2022 14:52
@userquin
Copy link
Member Author

I'll fix the PWA

@userquin userquin marked this pull request as ready for review June 26, 2022 10:57
@userquin
Copy link
Member Author

userquin commented Jun 26, 2022 •
edited
Loading

I need to add some images to the PWA, for example the screenshots for UI and IDE.

@userquin userquin marked this pull request as draft June 26, 2022 11:54
@userquin
chore: add pwa runtime caching for external images (UI/IDE)
cc3e1af 
chore: add Inter fonts to the workbox cache (VitePress?)
@userquin
Copy link
Member Author

userquin commented Jun 26, 2022 •
edited
Loading

added offline support for external images and the Inter font (being used by Vitepess?).

Maybe we can download also the images for UI/IDE to local instead using them from external links: the PWA cache storage is about 60MB due to opaque resources.

@userquin userquin marked this pull request as ready for review June 26, 2022 12:11
@patak-dev
Copy link
Member

Still not there, even after cleaning the data. The link is there though, maybe an issue with styles? Maybe it is about the changes you added to support better alignment?

image

@userquin
Copy link
Member Author

Still not there, even after cleaning the data. The link is there though, maybe an issue with styles? Maybe it is about the changes you added to support better alignment?

It seems a problem with the ab block addon: it works in Windows using Edge, Chrome, Chrome Canary and Firefox, and also on Safari in MacOS.

I'm fixing it...

@userquin userquin mentioned this pull request Jun 26, 2022
Closed
3 tasks
@patak-dev
Copy link
Member

Works now after clearing the site data 👍🏼

@antfu antfu merged commit ea02834 into main Jun 26, 2022
@antfu antfu deleted the userquin/docs-update-theme branch June 26, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@userquin @antfu @patak-dev